Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40694 )
Change subject: soc/intel/apl: Add panel power and backlight configuration ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40694/1/src/drivers/intel/gma/i915_... File src/drivers/intel/gma/i915_reg.h:
https://review.coreboot.org/c/coreboot/+/40694/1/src/drivers/intel/gma/i915_... PS1, Line 1717: /* BXT backlight register definition. */
No dot/period at the end needed.
It's a copy from Linux.
https://review.coreboot.org/c/coreboot/+/40694/1/src/drivers/intel/gma/i915_... PS1, Line 1728: \
I just sync'ed it with Linux as best as I could ;)
It's a copy from Linux.
https://review.coreboot.org/c/coreboot/+/40694/1/src/soc/intel/apollolake/gr... File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/40694/1/src/soc/intel/apollolake/gr... PS1, Line 40: i
Hmmm, written out, it's `index`. But that's what `i` almost always means... […]
Changed it to `idx`. Don't know if that's better due to lack of feedback.