Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78543?usp=email )
Change subject: mb/google/hatch: Change WiFi device type from PCI to generic
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I just want to note that we discussed the pros & cons of this change. It *is* a pci device, but it's using a bogus device/func, which says that it doesn't actually need any of the PCI information. Because the device is already inside a generic driver, it seems entirely appropriate to continue with it as a generic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieab0722a81f0952bb5b6df8e60c4d684ff455418
Gerrit-Change-Number: 78543
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 01 Nov 2023 15:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment