Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34512 )
Change subject: mb/google/octopus: Override VBT selection for Dorp
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34512/3/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/meep/variant.c:
https://review.coreboot.org/c/coreboot/+/34512/3/src/mainboard/google/octopu...
PS3, Line 16: #include <boardid.h>
Do we need this?
https://review.coreboot.org/c/coreboot/+/34512/3/src/mainboard/google/octopu...
PS3, Line 20: #include <console/console.h>
Do we need this?
https://review.coreboot.org/c/coreboot/+/34512/3/src/mainboard/google/octopu...
PS3, Line 34: return "vbt_dorp_hdmi.bin";
Cq-Depend: chrome-internal:1502253
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62262378f85bb899073ffac7804be876e649e429
Gerrit-Change-Number: 34512
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 13:58:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment