Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33141 )
Change subject: mb/*/{x201,ms2290}/mainboard.c: Remove superfluous ramstage code
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33141/2/src/mainboard/lenovo/x201/m...
File src/mainboard/lenovo/x201/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33141/2/src/mainboard/lenovo/x201/m...
PS2, Line 71: /* If we're resuming from suspend, blink suspend LED */
: if (acpi_is_wakeup_s3())
: ec_write(0x0c, 0xc7);
This is done in _SST. […]
Ack
https://review.coreboot.org/c/coreboot/+/33141/7/src/mainboard/lenovo/x201/m...
File src/mainboard/lenovo/x201/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33141/7/src/mainboard/lenovo/x201/m...
PS7, Line 47: outl(0, pmbase + SMI_EN);
Properly setting this up is done in southbridge_smm_init() in southbridge/intel/common/smi.c afaict.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0270c50dea2a2ce6c8e6114ed708f06be9d33c0e
Gerrit-Change-Number: 33141
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Sun, 15 Sep 2019 20:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment