Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47380 )
Change subject: mb/google/kukui: Add panel api after dsi start ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47380/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47380/7//COMMIT_MSG@9 PS7, Line 9: mipirx : enable enabling mipirx
Where is mipirx enabled BTW?
https://review.coreboot.org/c/coreboot/+/47380/7//COMMIT_MSG@12 PS7, Line 12: BUG=b:168728787 Add a blank line after BUG=...
https://review.coreboot.org/c/coreboot/+/47380/7/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/47380/7/src/mainboard/google/kukui/... PS7, Line 8: #include "panel.h" Please do not move it. Local headers should be put in a separate section (unless you write <panel.h>).
https://review.coreboot.org/c/coreboot/+/47380/7/src/mainboard/google/kukui/... PS7, Line 43: start_anx7625 Can we adjust the order to match the initialization of anx7625_panel?
static struct panel_serializable_data anx7625_data = ... dummy_power_on start_anx7625