Attention is currently required from: Cliff Huang, Intel coreboot Reviewers.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/86414?usp=email )
Change subject: soc/intel/common/gpio: Add macro for interrupt GPI with driver mode
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/86414/comment/0b7ffb8a_93118dd6?usp... :
PS3, Line 440: #define PAD_CFG_GPI_APIC_DRIVER(pad, pull, rst, trig, inv) \
As you have reported, this suggestion does not work. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86414?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc1ed3089c24302bc7eb02318714b8ec464fad01
Gerrit-Change-Number: 86414
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Comment-Date: Wed, 19 Feb 2025 21:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com