Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38947 )
Change subject: mb/hatch + soc/intel/cannonlake: Enable TetonGlacierMode on hatch
......................................................................
Patch Set 1:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/...
PS1, Line 54: TetonGlacierMode
Is there maybe a better name for this? NvmeAutoLaneCount or something?
please don't.... nvme_auto_lane_count ;)
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/...
PS1, Line 333: X2
x2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If775b40e6922ac7d111ac00c7c51eec6623ed4df
Gerrit-Change-Number: 38947
Gerrit-PatchSet: 1
Gerrit-Owner: David Jimenez
dvjimenez@chromium.org
Gerrit-Reviewer: David Jimenez
dvjimenez@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 10:26:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment