Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30848 )
Change subject: mb/emulation/qemu-i440fx: add e820 interface ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/30848/4/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/30848/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 105: add description what this functions returns. What's returned on error.
https://review.coreboot.org/#/c/30848/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 106: unsigned long fw_cfg_cbmem_top(void) please name it tolud, to make clear that is the top of dram below 4 GiB. It's not related to cbmem at all. return uintptr_t
https://review.coreboot.org/#/c/30848/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 114: uint64_t limit = (uint64_t)e.address + e.length; no need for cast. e.address is of type uint64_t