Attention is currently required from: Matt DeVillier, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/46635 )
Change subject: gfx gma skylake: Implement some workarounds ......................................................................
Patch Set 7: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/46635/comment/d43e9231_ad5969f8 PS7, Line 11: workarounds, the system no longer locks up after running gfx_test. Please describe the full sequence that leads to a hang. Was i915 involved in any way? Also, did you test if low-power states work when booting with coreboot+libgfxinit w/o these WAs but i915 disabled?
Patchset:
PS7: Thanks for boiling it down to 2 WAs.
File common/skylake/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/46635/comment/bff2d262_e08d0069 PS7, Line 359: 1 * 2 ** 13 i915 calls it MASK_WAKEMEM