build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32020 )
Change subject: [WIP]x86: Introduce the blobolator ......................................................................
Patch Set 13:
(146 comments)
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/Kco... File src/arch/x86/libx86emu/Kconfig.debug:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/Kco... PS13, Line 21: IO access can be traced, analysed, modified or droped. 'droped' may be misspelled - perhaps 'dropped'?
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... File src/arch/x86/libx86emu/blobolator.c:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 43: x86emu_mem_t *emu_mem_new(unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 48: void x86emu_set_io_perm(x86emu_t *emu, unsigned start, unsigned end, unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 48: void x86emu_set_io_perm(x86emu_t *emu, unsigned start, unsigned end, unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 48: void x86emu_set_io_perm(x86emu_t *emu, unsigned start, unsigned end, unsigned perm) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 52: unsigned x86emu_read_byte(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 52: unsigned x86emu_read_byte(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 56: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 62: unsigned x86emu_read_byte_noperm(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 62: unsigned x86emu_read_byte_noperm(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 66: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 73: unsigned x86emu_read_word(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 73: unsigned x86emu_read_word(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 77: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 83: unsigned x86emu_read_dword(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 83: unsigned x86emu_read_dword(x86emu_t *emu, unsigned addr) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 87: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 93: void x86emu_write_byte(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 93: void x86emu_write_byte(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 97: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 101: void x86emu_write_byte_noperm(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 101: void x86emu_write_byte_noperm(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 105: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 110: void x86emu_write_word(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 110: void x86emu_write_word(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 114: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 118: void x86emu_write_dword(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 118: void x86emu_write_dword(x86emu_t *emu, unsigned addr, unsigned val) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 122: if(emu) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 126: unsigned x86emu_clear_log(x86emu_t *emu, int flush) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 128: if(flush && emu->log.flush) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 129: if(emu->log.ptr && emu->log.ptr != emu->log.buf) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 134: if((emu->log.ptr = emu->log.buf)) *emu->log.ptr = 0; space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 134: if((emu->log.ptr = emu->log.buf)) *emu->log.ptr = 0; do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 134: if((emu->log.ptr = emu->log.buf)) *emu->log.ptr = 0; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 171: emu->x86.R_EIP, 's', 'O', emu->x86.R_ECX, emu->x86.R_EDX, emu->x86.R_EAX); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 207: memset(x86, 0, sizeof *x86); sizeof *x86 should be sizeof(*x86)
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 262: __weak void vm_traceio_w(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 266: __weak void vm_traceio_r(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 270: unsigned vm_memio(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 270: unsigned vm_memio(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 273: unsigned bits = type & 0xff; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 278: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 280: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 294: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 308: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 323: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 337: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 367: static bool x86emu_memio_drop(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 369: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 384: static bool x86emu_memio_except(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 389: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 421: static unsigned x86emu_memio_handler(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 421: static unsigned x86emu_memio_handler(struct x86emu_s *emu_s, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 490: static int x86emu_intr_handler(x86emu_t *emu, u8 num, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 503: vm_memio(emu, emu->x86.R_EIP + i - 16, &val, X86EMU_MEMIO_R|X86EMU_MEMIO_8); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 516: static void x86emu_flush_log(x86emu_t *emu, char *buf, unsigned size) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 615: for (int j = 0; j < length; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... File src/arch/x86/libx86emu/blobolator_internal.h:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 18: void vm_traceio_w(x86emu_t *emu, u32 addr, u32 *val, unsigned type); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 19: void vm_traceio_r(x86emu_t *emu, u32 addr, u32 *val, unsigned type); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 25: void (*init)(x86emu_t *emu); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 25: void (*init)(x86emu_t *emu); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 26: bool (*ignore_addr_io)(x86emu_t *emu, u32 addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 26: bool (*ignore_addr_io)(x86emu_t *emu, u32 addr); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 27: bool (*ignore_addr_mem)(x86emu_t *emu, u32 addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/blo... PS13, Line 27: bool (*ignore_addr_mem)(x86emu_t *emu, u32 addr); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... File src/arch/x86/libx86emu/trace-bios.c:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 28: if (addr > 0xffffffff - CONFIG_ROM_SIZE) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... File src/arch/x86/libx86emu/trace-pci.c:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 52: devfn >> 3, devfn & 7); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 79: static struct bar_tracer *bar_trace_find(struct device *dev, unsigned int bar, unsigned int type) line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 165: DEVFN_T dev = ((bus << 20)| devfn << 12); need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 169: if (!dev) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 201: while (!(moving & size)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 210: tracer = bar_trace_add(pcidev_path_on_root(devfn), (index - 0x10) / 4, !!(attr & PCI_BASE_ADDRESS_SPACE_IO)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 232: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 232: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 261: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 261: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 290: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 290: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 320: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 320: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 381: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 417: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 460: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 462: if (addr < 0xcfc) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 469: if (addr < 0xcfc) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 476: if (addr < 0xcfc) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 490: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 506: if (conf >= PCI_BASE_ADDRESS_0 && conf < (PCI_BASE_ADDRESS_5 + 4) && !(conf & 3)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 523: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 539: if (conf >= PCI_BASE_ADDRESS_0 && conf < (PCI_BASE_ADDRESS_5 + 4) && !(conf & 3)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... File src/arch/x86/libx86emu/trace-skl.c:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 34: switch (devfn) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 87: devfn >> 3, devfn & 7); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 95: if (addr > 0x78000000 && addr < 0x78510000) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 129: bool pci_trace_p2sb_r(const int bus, const int devfn, const int off, u32 *val, unsigned int bits) line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 137: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 139: if (off >= P2SB_CR_SBI_ADDR && off < (P2SB_CR_SBI_ADDR + 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 148: if (off >= P2SB_CR_SBI_ADDR && off < (P2SB_CR_SBI_ADDR + 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 157: if (off >= P2SB_CR_SBI_ADDR && off < (P2SB_CR_SBI_ADDR + 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 167: if (!(sb_data.w & 1) && pending ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 167: if (!(sb_data.w & 1) && pending ) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 172: bool pci_trace_p2sb_w(const int bus, const int devfn, const int off, u32 *val, unsigned int bits) line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 180: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 182: if (off >= P2SB_CR_SBI_ADDR && off < (P2SB_CR_SBI_ADDR + 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 191: if (off >= P2SB_CR_SBI_ADDR && off < (P2SB_CR_SBI_ADDR + 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 200: if (off >= P2SB_CR_SBI_ADDR && off < (P2SB_CR_SBI_ADDR + 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 210: if ((sb_data.w & 1) && !pending ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 210: if ((sb_data.w & 1) && !pending ) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... File src/arch/x86/libx86emu/trace.c:
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 56: addr < ( (uintptr_t)baseptr + size)) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 62: addr < ((uintptr_t)cbmem_entry_start(ramstage_entry) + (uintptr_t)cbmem_entry_size(ramstage_entry))) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 91: void vm_traceio_r(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 102: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 107: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 119: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 119: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 121: printk(BIOS_DEBUG, " read8(0x%08x) // = 0x%x\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 124: printk(BIOS_DEBUG, " read16(0x%08x) // = 0x%x\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 127: printk(BIOS_DEBUG, " read32(0x%08x) // = 0x%x\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 133: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 138: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 150: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 150: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 152: printk(BIOS_DEBUG, " inb(0x%04x) // = 0x%x\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 155: printk(BIOS_DEBUG, " inw(0x%04x) // = 0x%x\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 158: printk(BIOS_DEBUG, " inl(0x%04x) // = 0x%x\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 166: void vm_traceio_w(x86emu_t *emu, u32 addr, u32 *val, unsigned type) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 168: const unsigned bits = type & 0xff; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 177: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 182: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 194: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 194: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 196: printk(BIOS_DEBUG, " write8(0x%08x, 0x%x)\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 199: printk(BIOS_DEBUG, "write16(0x%08x, 0x%x)\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 202: printk(BIOS_DEBUG, "write32(0x%08x, 0x%x)\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 208: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 213: for (driver = &_blobolator_drivers[0]; driver != &_eblobolator_drivers[0]; driver++) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 225: switch(bits) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 225: switch(bits) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 227: printk(BIOS_DEBUG, " outb(0x%04x, 0x%x))\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 230: printk(BIOS_DEBUG, " outw(0x%04x, 0x%x)\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/arch/x86/libx86emu/tra... PS13, Line 233: printk(BIOS_DEBUG, " outl(0x%04x, 0x%x)\n", addr, *val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/32020/13/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-q35/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32020/13/src/mainboard/emulation/qe... PS13, Line 85: if (myconfig->config1 || myconfig->config2) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/mainboard/emulation/qe... PS13, Line 88: if (myconfig->config3 != 0 && myconfig->config3 != 2) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/mainboard/emulation/qe... PS13, Line 91: if (myconfig->config1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/mainboard/emulation/qe... PS13, Line 94: if (myconfig->config2) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/32020/13/src/mainboard/emulation/qe... PS13, Line 98: if (myconfig->config5) { braces {} are not necessary for single statement blocks