Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35399 )
Change subject: lib/trace: Replace __PRE_RAM__ use
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35399/3/src/include/trace.h
File src/include/trace.h:
https://review.coreboot.org/c/coreboot/+/35399/3/src/include/trace.h@19
PS3, Line 19: ENV_ROMSTAGE_OR_BEFORE
We build lib/trace.c for postcar and ramstage, so I chose this. Maybe lack of . […]
Ok. I just wanted to confirm.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35399
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I957be92594aced2e8465e7f94d8d42e44c3418d7
Gerrit-Change-Number: 35399
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Sep 2019 15:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment