build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: support DDR frequency 3600Mbps ......................................................................
Patch Set 1:
(186 comments)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1721: static void dramc_duty_set_dqs_delay(u8 chn, s8* s_dqsDelay) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1724: s8 dqsDelay ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1728: dqsDelay = s_dqsDelay[dqs] ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1867: MR01Value[FSP_0] |= (0x5 << 4); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1868: MR01Value[FSP_1] |= (0x5 << 4); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1873: MR01Value[FSP_0] |= (0x5 << 4); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1874: MR01Value[FSP_1] |= (0x5 << 4); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1879: MR01Value[FSP_0] |= (0x6 << 4); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1880: MR01Value[FSP_1] |= (0x6 << 4); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1893: dramc_dbg("%s CH%u RK%u, freq:%d\n", __func__, chn, rank, freqTbl[freq_group]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1937: if (operate_fsp == FSP_0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1937: if (operate_fsp == FSP_0) suspect code indent for conditional statements (24, 28)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1941: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1941: else suspect code indent for conditional statements (24, 28)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1941: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1968: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1969: u8 dqsinctl; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1970: u8 datlat; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1971: u8 trcd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1972: u8 trrd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1973: u8 twr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1974: u8 twtr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1975: u8 trc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1976: u8 tras; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1977: u8 trp; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1978: u8 trpab; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1979: u8 tfaw; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1980: u8 trtw_ODT_on; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1981: u8 trtp; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1982: u8 txp; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1983: u8 refcnt; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1984: u8 trfc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1985: u8 trfcpb; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1986: u8 tzqcs; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1987: u8 refcnt_fr_clk; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1988: u8 txrefcnt; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1989: u8 tmrr2w_ODT_on; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1990: u8 twtpd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1991: u8 trtpd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1992: u8 xrtw2w; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1993: u8 xrtw2r; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1994: u8 xrtr2w; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1995: u8 xrtr2r; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1996: u8 twtr_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1997: u8 trtw_ODT_on_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1998: u8 twtpd_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1999: u8 trtpd_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2000: u8 tfaw_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2001: u8 trrd_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2002: u8 twr_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2003: u8 tras_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2004: u8 trpab_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2005: u8 trp_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2006: u8 trcd_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2007: u8 trtp_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2008: u8 txp_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2009: u8 trfc_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2010: u8 trfcpb_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2011: u8 trc_05T; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2012: u8 r_dmcatrain_intv; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2013: u8 r_dmmrw_intv; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2014: u8 r_dmfspchg_prdcnt; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2015: u8 ckeprd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2016: u8 ckelckcnt; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2017: u8 zqlat2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2018: }ACTime_T; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2021: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2059: .tras = 8, .tras_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2059: .tras = 8, .tras_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2060: .trp = 5, .trp_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2060: .trp = 5, .trp_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2061: .trpab = 1, .trpab_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2061: .trpab = 1, .trpab_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2062: .trc = 16, .trc_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2062: .trc = 16, .trc_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2063: .trfc = 100, .trfc_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2063: .trfc = 100, .trfc_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2064: .trfcpb = 44, .trfcpb_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2064: .trfcpb = 44, .trfcpb_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2065: .txp = 1, .txp_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2065: .txp = 1, .txp_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2066: .trtp = 2, .trtp_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2066: .trtp = 2, .trtp_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2067: .trcd = 6, .trcd_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2067: .trcd = 6, .trcd_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2068: .twr = 12, .twr_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2068: .twr = 12, .twr_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2069: .twtr = 7, .twtr_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2069: .twtr = 7, .twtr_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2070: .trrd = 2, .trrd_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2070: .trrd = 2, .trrd_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2071: .tfaw = 7, .tfaw_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2071: .tfaw = 7, .tfaw_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2072: .trtw_ODT_on = 7, .trtw_ODT_on_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2072: .trtw_ODT_on = 7, .trtw_ODT_on_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2073: .refcnt = 97, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2073: .refcnt = 97, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2074: .refcnt_fr_clk = 101, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2074: .refcnt_fr_clk = 101, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2075: .txrefcnt = 119, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2075: .txrefcnt = 119, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2076: .tzqcs = 34, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2076: .tzqcs = 34, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2077: .xrtw2w = 5, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2077: .xrtw2w = 5, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2078: .xrtw2r = 3, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2078: .xrtw2r = 3, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2079: .xrtr2w = 6, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2079: .xrtr2w = 6, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2080: .xrtr2r = 9, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2080: .xrtr2r = 9, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2081: .r_dmcatrain_intv = 11, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2081: .r_dmcatrain_intv = 11, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2082: .r_dmmrw_intv = 0xf, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2082: .r_dmmrw_intv = 0xf, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2083: .r_dmfspchg_prdcnt = 100, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2083: .r_dmfspchg_prdcnt = 100, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2084: .trtpd = 11, .trtpd_05T = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2084: .trtpd = 11, .trtpd_05T = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2085: .twtpd = 12, .twtpd_05T = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2085: .twtpd = 12, .twtpd_05T = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2086: .tmrr2w_ODT_on = 10, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2086: .tmrr2w_ODT_on = 10, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2087: .ckeprd = 2, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2087: .ckeprd = 2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2088: .ckelckcnt = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2088: .ckelckcnt = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2089: .zqlat2 = 12, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2089: .zqlat2 = 12, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2090: .dqsinctl = 4, .datlat = 15 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2090: .dqsinctl = 4, .datlat = 15 please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2117: .r_dmmrw_intv = 0xf, //Berson: LP3/4 both use this field -> Formula may change, set to 0xF for now line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2202: u1ROOT = 0; u1TXRANKINCTL=0; u1TXDLY=1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2202: u1ROOT = 0; u1TXRANKINCTL=0; u1TXDLY=1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2208: u1TXRANKINCTL=1; u1TXDLY=2; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2208: u1TXRANKINCTL=1; u1TXDLY=2; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2238: (twtr_05T << 25) | (trtw_ODT_on_05T << 24) | (twtpd_05T << 16) | (trtpd_05T << 15) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 2239: (tfaw_05T << 13) | (trrd_05T << 12) | (twr_05T << 10) | (tras_05T << 9) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 152: 0x7 << 4 | 0x1 << 7 | 0x3 <<0, need consistent spacing around '<<' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 165: tmp_2t = (read32(reg_1) >> shift) & DQ_DIV_MASK ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 265: if (wrlevel_dq_delay >= 0x40) { suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 872: u32 fsp = ( (freq_group == LP4X_DDR1600) ? FSP_0: FSP_1); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 872: u32 fsp = ( (freq_group == LP4X_DDR1600) ? FSP_0: FSP_1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 942: ((u32) dly_coarse_large << 8) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 942: ((u32) dly_coarse_large << 8) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 942: ((u32) dly_coarse_large << 8) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 944: ((u32) dly_coarse_large << 24) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 944: ((u32) dly_coarse_large << 24) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 944: ((u32) dly_coarse_large << 24) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 952: ((u32) dly_coarse_0p5t << 8) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 952: ((u32) dly_coarse_0p5t << 8) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 952: ((u32) dly_coarse_0p5t << 8) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 954: ((u32) dly_coarse_0p5t << 24) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 954: ((u32) dly_coarse_0p5t << 24) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 954: ((u32) dly_coarse_0p5t << 24) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 962: (dly_coarse_large_rodt << 8) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 962: (dly_coarse_large_rodt << 8) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 962: (dly_coarse_large_rodt << 8) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 964: (dly_coarse_large_rodt << 24) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 964: (dly_coarse_large_rodt << 24) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 964: (dly_coarse_large_rodt << 24) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 972: (dly_coarse_0p5t_rodt << 8) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 972: (dly_coarse_0p5t_rodt << 8) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 972: (dly_coarse_0p5t_rodt << 8) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 974: (dly_coarse_0p5t_rodt << 24) | code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 974: (dly_coarse_0p5t_rodt << 24) | please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 974: (dly_coarse_0p5t_rodt << 24) | please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1112: while (!wait_us(10, read32(&ch[chn].nao.spcmdresp) & suspect code indent for conditional statements (8, 17)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1114: if (loop++ > 10) Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1269: virtual_delay = (((((tx_dly >> (dqs << 2)) & 0x7) << mck) + ((dly >> (dqs << 2)) & 0x7)) << 5) + line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1391: dramc_dbg(" %s win_size_sum:%d, max_win:%d, vref_dly->min_win :%d, min_win_size_vref:%d \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1392: __func__, win_size_sum, vref_dly->max_win, vref_dly->min_win, min_win_size_vref); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1473: 0x77777777, dq_small| (dq_small_oen << 16)); need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1796: dq_perbit_dly[bit].dqdly.best_last - dq_perbit_dly[bit].dqdly.best_first, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/dra... PS1, Line 1799: dramc_dbg(" \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/emi... PS1, Line 274: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/emi... PS1, Line 283: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 42: { open brace '{' following enum go on the same line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 43: LP4X_DDR1600, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 44: LP4X_DDR3200, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 45: LP4X_DDR3600, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 46: LP4X_DDRFREQ_MAX, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 50: { open brace '{' following enum go on the same line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 51: DDR_FREQ_1600 = 1600, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 52: DDR_FREQ_3200 = 3200, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34332/1/src/soc/mediatek/mt8183/inc... PS1, Line 53: DDR_FREQ_3600 = 3600, please, no spaces at the start of a line