Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add new ENV_xxx definitions ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34939/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34939/10//COMMIT_MSG@9 PS10, Line 9: ENV_BEFORE_RAMSTAGE is the generic replacement for __PRE_RAM__.
I think it would make more sense that ENV_ROMSTAGE_OR_BEFORE is the new generic replacement for __PR […]
I am fine with either. Let's wait until we can review (pending) followup work to see how much we really need to use this.
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h@276 PS10, Line 276: !CONFIG(ARCH_X86)
Well, if you want to know whether you have a . […]
As this patchset demonstrates, ENV_CACHE_AS_RAM seems to have no use outside x86 <arch/early_variables.h> and we could wipe it out with next release.
Looking into non-x86 arch, I see three cases of __PRE_RAM__ left, CB:34892. The people workin on systems with SRAM never needed to make the distinction between SRAM/DRAM? I'll name it _IN_DRAM now, let's see what the followups utilising these end up looking like before making the final calls.