Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32339 )
Change subject: mediatek/mt8183: Enable RTC eosc calibration feature to save power ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32339/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32339/3//COMMIT_MSG@10 PS3, Line 10: need needs
https://review.coreboot.org/#/c/32339/3//COMMIT_MSG@10 PS3, Line 10: power. Then coreboot RTC driver need to call rtc_enable_dcxo function How much power is saved?
https://review.coreboot.org/#/c/32339/3/src/soc/mediatek/mt8183/rtc.c File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/#/c/32339/3/src/soc/mediatek/mt8183/rtc.c@307 PS3, Line 307: using Use
https://review.coreboot.org/#/c/32339/3/src/soc/mediatek/mt8183/rtc.c@309 PS3, Line 309: fail failed