Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46304 )
Change subject: include/device/device.h: Move resource debug macros
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@918
PS4, Line 918: # Only visible if DEBUG_SPEW (8) is set. It does additional printk(BIOS_DEBUG, ...) calls.
: config HAVE_DEBUG_RESOURCES
: def_bool n
Any reason to have this platform specific flag?
Yeah, it seems this Kconfig flag could be removed entirely. It does not look like any requirements exist external to the resource allocator to use these debug functions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bdab7770ca5ee5901f17a8af3a9a1001b6702e4
Gerrit-Change-Number: 46304
Gerrit-PatchSet: 4
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 18:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment