Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 50: chip drivers/usb/acpi : register "desc" = ""Right Type-A Port"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 2.1 on end : end In the baseboard, this was on port 2.3. If we are not using that port, can we turn it off here. Same comment for the usb 3.3 port.
Also if port 3 is not used, you have to mark register "usb2_ports[3]" = "USB2_PORT_EMPTY" # Not Used
register "usb3_ports[3]" = "USB3_PORT_EMPTY" # USB3/1 Type-A Port A1
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 79: GPP_B3 GPP_B3_IRQ. Same comment for Synaptics touchpad as well.
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 99: GPP_D4 GPP_D4_IRQ
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 104: "3" Nit: 2 ms is sufficient. Atleast that is what I see in other variants using similar Goodix TS.