Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40922 )
Change subject: src/soc/amd/picasso: Add methods to save and restore MTRRs ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40922/4/src/soc/amd/picasso/mtrr.c File src/soc/amd/picasso/mtrr.c:
https://review.coreboot.org/c/coreboot/+/40922/4/src/soc/amd/picasso/mtrr.c@... PS4, Line 105: (tmp_sys_cfg.lo & SYS_CFG_MTRR_BITS) != (sys_cfg.lo & SYS_CFG_MTRR_BITS) This could be changed to a update_if_changed_with_mask() that takes in mask for hi and lo and updates accordingly and also have update_if_changed() call it with 0xffffffff mask. But since the whole thing is meant to go away anyways, I think this is fine.