Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45910 )
Change subject: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45910/1/src/mainboard/opencellular/...
File src/mainboard/opencellular/elgon/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45910/1/src/mainboard/opencellular/...
PS1, Line 65: printk(BIOS_INFO, "MB: REFclk : %"PRIu64 " MHz\n",
i'd add a space between the first part of the format string and the PRIu64
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d3f01094cc281d76ffbc9bc4bae1bbf37ffa70
Gerrit-Change-Number: 45910
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 01 Oct 2020 23:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment