Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32858 )
Change subject: console: Move poor-man's atoi() into string.h
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32858/4/src/include/string.h
File src/include/string.h:
https://review.coreboot.org/#/c/32858/4/src/include/string.h@182
PS4, Line 182: /* Parses an unsigned integer and moves the input pointer forward to the first
: character that's not a valid digit. s and *s must not be NULL. Result
: undefined if it overruns the return type size. */
I though for headers the elaborate multi-line comment style (and not concise) should be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32858
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb2b970aecfc768540d2bf8b3023445f54853a4
Gerrit-Change-Number: 32858
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 09:47:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment