Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47492 )
Change subject: nb/intel/sandybridge: Use arrays to program IOSAV
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_iosav.c:
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy...
PS1, Line 32: ssq_count
I specifically want to remove this assignment. […]
I still added a check for ssq_count == 0, since that would overflow within the register write.
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy...
PS1, Line 21: ssq_count
d'oh, good catch
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica1b2b20e04ae368f10aa236ca24d12f69464430
Gerrit-Change-Number: 47492
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 09:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment