Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Add dpm loader
......................................................................
Patch Set 40:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46393/40/src/soc/mediatek/mt8192/Ma...
File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46393/40/src/soc/mediatek/mt8192/Ma...
PS40, Line 56: $(CONFIG_DPM_DM_FIRMWARE) \
: $(CONFIG_DPM_PM_FIRMWARE) \
: $(CONFIG_MCUPM_FIRMWARE) \
No need to put \ in same column.
Just add
$(CONFIG_DPM_DM_FIRMWARE) \
$(CONFIG_DPM_PM_FIRMWARE) \
And not touching MCUPM line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16b341ad63940b45b886c4a7fd733c1970624e40
Gerrit-Change-Number: 46393
Gerrit-PatchSet: 40
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 08 Dec 2020 09:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment