Attention is currently required from: Matt DeVillier, Angel Pons, Arthur Heymans, Alexander Couzens.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72496 )
Change subject: nb/intel/snb: Abolish mainboard_should_reset_usb()
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72496/comment/3f6b11be_23372d69
PS7, Line 9: Of the 13 mainboards that implement mainboard_should_reset_usb() hook,
: only samsung/stumpy does things differently. Turn the majority
: implementation into a __weak default that this one board will override.
SGTM
Thanks everyone. I submitted an update taking it all the way. Matt, please test this on hardware. (Everything was so tightly dependent everything has to go in at once or build would break.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e
Gerrit-Change-Number: 72496
Gerrit-PatchSet: 8
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 21 Mar 2023 03:02:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment