Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Marek Maślanka, Paul Menzel, Tim Wawrzynczak.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79380?usp=email )
Change subject: acpi: Add support for WDAT table
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Patchset:
PS5:
JFYI: I cannot add V+1, but we tested this change on physical device and it works correctly.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/79380/comment/040c2669_56c2bd62 :
PS4, Line 1887: unsigned long acpi_soc_fill_wdat(acpi_wdat_t *wdat, unsigned long current);
I know I'm nit-picking, but please write a comment describing how this function should be implemente […]
Thank you very much. It's small but important step in documenting coreboot codebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79380?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb82d1f69b2b7fffacfd2928bc71f8ff10498074
Gerrit-Change-Number: 79380
Gerrit-PatchSet: 5
Gerrit-Owner: Marek Maślanka
mmaslanka@google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Marek Maślanka
mmaslanka@google.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 13 Dec 2023 16:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Gerrit-MessageType: comment