Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34929 )
Change subject: arch/x86: Fix spinlocks for cases of __PRE_RAM__
......................................................................
Patch Set 4:
Patch Set 4:
This commit may be the last place evaluating defined(__PRE_RAM__) and I don't have too many ideas of howto proceed with this to make it clean.
I am not sure if we need/want -D__PRE_RAM__ anymore for CPPFLAGS.
I skimmed the patch and didn't see a __PRE_RAM__ reference. If we waren't using it any longer I think it's fine to remove from CPPFLAGS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00da5c2b0570c26f2e3bb464274485cc2c08c8f0
Gerrit-Change-Number: 34929
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Sep 2019 15:12:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment