Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32414 )
Change subject: arch/x86: Add option for using a custom assembly_entry
......................................................................
Patch Set 9:
(1 comment)
I quess you could have split this such that everything about postcar first got removed. But as long as this is going forwards..
https://review.coreboot.org/c/coreboot/+/32414/9/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/32414/9/src/Kconfig@160
PS9, Line 160: for early stages.
It could just be here to help guide people who are thinking of utilizing the functionality. […]
Could this be named RESET_VECTOR_IN_DRAM? If so, you could use that to corrcetly leave ENV_CACHE_AS_RAM in <rules.h> unset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I678b1f74546ea30abcc655a0daed795d6cfa0034
Gerrit-Change-Number: 32414
Gerrit-PatchSet: 9
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Wed, 14 Aug 2019 23:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment