29 Apr
2019
29 Apr
'19
7:43 a.m.
Martin Kepplinger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32499 )
Change subject: x86emu: add console.h header to fix compilation ......................................................................
Patch Set 2:
Patch Set 2:
why don't you include <console.h> here "src/device/oprom/x86emu/debug.h" instead of src/device/oprom/include/x86emu/x86emu.h ?
I've put it where it's been before. Should I change it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75d0b7c08bfa6dcb07778bbb762223b62cfc3da7
Gerrit-Change-Number: 32499
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Kepplinger martink@posteo.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Kepplinger martink@posteo.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Apr 2019 05:43:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment