26 Jan
2021
26 Jan
'21
10:38 p.m.
Attention is currently required from: Tim Crawford. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47962 )
Change subject: mb/system76/oryp5: Enable TAS5825M smart amp ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/system76/oryp5/tas5825m.c:
https://review.coreboot.org/c/coreboot/+/47962/comment/8fcb45e2_36f8ad28 PS5, Line 8: return
I suppose this could just OR the result and return res at the end.
You could also rewrite this with arrays
--
To view, visit https://review.coreboot.org/c/coreboot/+/47962
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148f18ff3e754d913bdf907121b103c6de02ffc3
Gerrit-Change-Number: 47962
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 22:38:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford tcrawford@system76.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment