Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51704 )
Change subject: soc/intel/alderlake: Align RcompResistor definition as per MRC
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
@Subrata: I'd suggest rebasing this patch train so that this change is in first place.
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/51704/comment/ae9c6803_5551e21b
PS2, Line 20: &
No `&` here, `RcompTarget` is an array.
While this shouldn't cause issues (the pointer value is the same), I'd still drop the `&`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69c7cec55b65036fc039c33374a3fd363ef7004e
Gerrit-Change-Number: 51704
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Mar 2021 11:34:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment