Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40545 )
Change subject: arch/x86/smbios: Add SMBIOS type8 data ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40545/4/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/40545/4/src/arch/x86/smbios.c@894 PS4, Line 894: const struct port_information *__weak smbios_get_port_info(size_t *num_ports) that's usually used to option a single string or object
https://review.coreboot.org/c/coreboot/+/40545/4/src/arch/x86/smbios.c@900 PS4, Line 900: static int smbios_write_type8(unsigned long *current, int *handle) I'd prefer a "type9" or "type38" solution. That is either implement smbios_walk_device_tree_type8 or call smbios_write_type8 in the mainboard.c by iterating over the connectors, like it's done for smbios_write_type38.