Attention is currently required from: Paul Menzel, Patrick Rudolph, HAOUAS Elyes.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60056 )
Change subject: nb/intel/i945/raminit.c: Set "integrated_graphics" as bool
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60056/comment/3bb5c8b6_f638d31d
PS1, Line 8:
even if it was an "int", "integrated_graphics" is already used as a "bool" at line #2128 ("integrat […]
Please write that in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5286e691c312e8e44bbbd8e782fdfd4a13cb60f
Gerrit-Change-Number: 60056
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 12 Dec 2021 15:32:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment