Attention is currently required from: Angel Pons.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/hp/pro_3x00_series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/85825/comment/6a37fa8e_351984af?usp... :
PS1, Line 26: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
For a follow-up: this doesn't make sense on a desktop and can be removed.
True, left that in from the original not even thinking about removing it.
Follow-up here: CB:85847.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 7
Gerrit-Owner: Václav Straka
venda.straka@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 04 Jan 2025 01:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com