Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32657 )
Change subject: soc/amd/stoneyridge: Move IOMMU support to common
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu...
File src/soc/amd/common/block/iommu/iommu.c:
https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu...
PS4, Line 46: 0
DEVICE_NOOP?
https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu...
PS4, Line 47: 0
DEVICE_NOOP?
https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu...
PS4, Line 54: PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU
This will have to be transformed into a list of pci device_ids.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb02180645c9e7e6dc973438c777228b031b3f54
Gerrit-Change-Number: 32657
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 May 2019 23:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment