Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28596 )
Change subject: mb/asrock/g41m_vs3_r2: Add mainboard ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/28596/5/src/mainboard/asrock/g41c-gs/gpio.c File src/mainboard/asrock/g41c-gs/gpio.c:
https://review.coreboot.org/#/c/28596/5/src/mainboard/asrock/g41c-gs/gpio.c@... PS5, Line 75: #if IS_ENABLED(CONFIG_BOARD_ASROCK_G41M_VS3_R2_0) : .gpio8 = GPIO_LEVEL_LOW, : .gpio9 = GPIO_LEVEL_LOW, : #endif
this IS_ENABLED(CONFIG_BOARD_ASROCK_G41M_VS3_R2_0) is always false, since it's inside the IS_ENABLED […]
This file is becoming a mess. I'll just link them separately, while removing the preprocessor statements I think...