Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35141 )
Change subject: mb/google/drallion: Add memory init setup for drallion ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 180: /*_PCH_MEM_STRAP0_*/ PAD_CFG_GPI(GPP_F12,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 180: /*_PCH_MEM_STRAP0_*/ PAD_CFG_GPI(GPP_F12,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 181: /*_PCH_MEM_STRAP1_*/ PAD_CFG_GPI(GPP_F13,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 181: /*_PCH_MEM_STRAP1_*/ PAD_CFG_GPI(GPP_F13,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 182: /*_PCH_MEM_STRAP2_*/ PAD_CFG_GPI(GPP_F14,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 182: /*_PCH_MEM_STRAP2_*/ PAD_CFG_GPI(GPP_F14,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 183: /*_PCH_MEM_STRAP3_*/ PAD_CFG_GPI(GPP_F15,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 183: /*_PCH_MEM_STRAP3_*/ PAD_CFG_GPI(GPP_F15,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 184: /*_PCH_MEM_STRAP4_*/ PAD_CFG_GPI(GPP_F16,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35141/4/src/mainboard/google/dralli... PS4, Line 184: /*_PCH_MEM_STRAP4_*/ PAD_CFG_GPI(GPP_F16,_NONE,_PLTRST),
space required after that ',' (ctx:VxV)
Done