Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36552 )
Change subject: soc/intel/tigerlake/romstage: Do initial SoC commit till romstage ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36552/1/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/36552/1/src/soc/intel/tigerlake/rom... PS1, Line 15: : #include <assert.h> : #include <console/console.h> unused
https://review.coreboot.org/c/coreboot/+/36552/1/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/36552/1/src/soc/intel/tigerlake/rom... PS1, Line 26: #include <soc/pci_devs.h> unused.
https://review.coreboot.org/c/coreboot/+/36552/1/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/systemagent.c:
https://review.coreboot.org/c/coreboot/+/36552/1/src/soc/intel/tigerlake/rom... PS1, Line 22: #include <device/device.h> unused?