Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39043 )
Change subject: lenovo/*: Fix DRAM init when WWAN card is present ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39043/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39043/6//COMMIT_MSG@10 PS6, Line 10: support SMBUS is installed, it pulls the lines low.
… ,that supports SMBus, …
Done
https://review.coreboot.org/c/coreboot/+/39043/6//COMMIT_MSG@12 PS6, Line 12: SMBUS
SMBus
Done
https://review.coreboot.org/c/coreboot/+/39043/6//COMMIT_MSG@15 PS6, Line 15: EEPROM
Sorry for being dense, but the EEPROMs on the memory modules containing SPD data?
Done
https://review.coreboot.org/c/coreboot/+/39043/6/src/mainboard/lenovo/t420/e... File src/mainboard/lenovo/t420/early_init.c:
https://review.coreboot.org/c/coreboot/+/39043/6/src/mainboard/lenovo/t420/e... PS6, Line 80: SMBUS
SMBus
Done
https://review.coreboot.org/c/coreboot/+/39043/6/src/mainboard/lenovo/t430/e... File src/mainboard/lenovo/t430/early_init.c:
https://review.coreboot.org/c/coreboot/+/39043/6/src/mainboard/lenovo/t430/e... PS6, Line 74: SMBUS
SMBus
Done