Attention is currently required from: Nico Huber, Peter Lemenkov, Alexander Couzens, Patrick Rudolph, amersel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
Patch Set 16:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/b11c3f8e_d00fcd66
PS14, Line 28: when IFD is unlocked
I haven't attempted internal flashing with a locked IFD so I'll leave that as untested for now. […]
In any case, the command would be:
sudo flashrom -p internal --ifd -i bios -w build/coreboot.rom --noverify-all
https://review.coreboot.org/c/coreboot/+/52659/comment/f0eda713_a4d8d5bd
PS14, Line 39: - Each boot takes 20s
Oh. Each boot should be corrected to first boot. […]
I know Haswell MRC.bin is slow, especially with 2DPC (2 DIMMs Per Channel). I've seen it take 20 seconds with 4 dual-rank DIMMs on my Asrock B85M Pro4. And I don't like it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 16
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: amersel
Gerrit-Comment-Date: Mon, 07 Jun 2021 14:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: amersel
Gerrit-MessageType: comment