Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35121 )
Change subject: soc/intel/skylake: Remove duplicated PCI Id
......................................................................
Patch Set 2:
(1 comment)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/35121/1/src/soc/intel/skylake/bootb...
File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/35121/1/src/soc/intel/skylake/bootb...
PS1, Line 57: { PCI_DEVICE_ID_INTEL_SKL_ID_S_4, "Skylake-S (4 Core)" },
"Skylake-S (4 Core) / Skylake-DT" maybe to make clear that it might be either one?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I028a22d6a42c040f5991a03def3e410f515c1c7f
Gerrit-Change-Number: 35121
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 28 Aug 2019 09:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment