[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common/firmware: Add an option to use IFDTOOL

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31639 )

Change subject: sb/intel/common/firmware: Add an option to use IFDTOOL
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31639/1/src/southbridge/intel/common/firmwar... 
File src/southbridge/intel/common/firmware/Makefile.inc:

https://review.coreboot.org/#/c/31639/1/src/southbridge/intel/common/firmwar... 
PS1, Line 86: cp $(obj)/coreboot.pre $(obj)/coreboot.pre.new
            : 	mv $(obj)/coreboot.pre.new $(obj)/coreboot.pre
> Isn't this effectively copying $(obj)/coreboot.pre to $(obj)/coreboot. […]

Yes, of course, you’re right. That stayed in from the first experiments with the IFDTOOL.