Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42904 )
Change subject: mb/google/nightfury: Override VBT selection for nightfury 2nd sku
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42904/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/nightfury/variant.c:
https://review.coreboot.org/c/coreboot/+/42904/1/src/mainboard/google/hatch/...
PS1, Line 10: uint32_t sku_id = google_chromeec_get_board_sku();
It doesn't have to be const, it just lets the compiler know the variable cannot be modified.
Sorry I meant `const uint32_t sku_id = google_chromeec_get_board_sku()`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9450814aadc43cc7991457c3793f109b889186b9
Gerrit-Change-Number: 42904
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 17:23:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: shkim
sh_.kim@samsung.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment