build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47512 )
Change subject: nb/intel/sandybridge: Use bitfields to program MCMAIN timings ......................................................................
Patch Set 7:
(13 comments)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 108: u32 : 8; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 130: u32 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 132: u32 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 134: u32 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 136: u32 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 138: u32 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 140: u32 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 143: u32 : 4; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 157: u32 : 12; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 164: u32 : 12; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 167: u32 : 18; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 178: u32 : 14; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/47512/7/src/northbridge/intel/sandy... PS7, Line 197: u32 : 2; space prohibited before that ':' (ctx:WxW)