HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: sc7180: Add display 10nm phy & pll programming support [Patch 1 of 3] ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39613/16/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/39613/16/src/soc/qualcomm/sc7180/di... PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 Qualcomm Inc. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License version 2 and : * only version 2 as published by the Free Software Foundation. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/39613/16/src/soc/qualcomm/sc7180/di... PS16, Line 16: include <device/mmio.h> : #include <lib.h> : #include <stdlib.h> : #include <console/console.h> : #include <delay.h> : #include <timer.h> : #include <string.h> : #include <stdint.h> : #include <sys/types.h> : #include <soc/clock.h> : #include <soc/display/mdssreg.h> : #include <soc/display/dsi_phy.h> : #include <soc/display/display_resources.h> would you please include only what you use
( I didn't checked the other files & patches)
https://review.coreboot.org/c/coreboot/+/39613/16/src/soc/qualcomm/sc7180/di... PS16, Line 1056: goto out return ret; ?