Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43308 )
Change subject: soc/amd/picasso: Init SPI speeds & mode in psp_verstage ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 1:
Patch Set 1:
Matt, Do the EFS settings remove the need for psp verstage to do this?
I dont know for sure, did not get a clear answer when I asked Avinash. Sure seems logical that is the case because otherwise what is the point? It is clearly working now without it.
I can find out for sure by taking the time before and after my change. Let me finish updating my patch stack and see what the results are. Martin, what improvement % on boot time were you seeing? Just to sanity check anything I see
Any progress Matt?
Let's just merge this, and if we don't need it, we can get rid of it. We currently don't know when the SPI speed gets changed. Is it in the PSP_bootloader? If not, we still need this. Either way, this shouldn't hurt anything.