Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34615 )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9 PS2, Line 9: PL4 to 82W
Is this good to keep the device up when booting without battery?
yes
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9 PS2, Line 9: PsysPL2 to 70W and PL4 to 82W
How were these values calculated?
Added detailed info on bug#c4. PL4 is as per the spec and PsysPL2 as per the calculated system power.
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@10 PS2, Line 10:
BUG=?
I will add bug info as BUG=138269131.