29 Apr
2019
29 Apr
'19
7:04 a.m.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32499 )
Change subject: x86emu: add console.h header to fix compilation ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32499/1/src/device/oprom/include/x86emu/x86e... File src/device/oprom/include/x86emu/x86emu.h:
https://review.coreboot.org/#/c/32499/1/src/device/oprom/include/x86emu/x86e... PS1, Line 45: #include <console/console.h> Once adding it back take care of the alphabetical order we have agreed on for includes? Doing so would mean to add console/console.h before stddef.h.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75d0b7c08bfa6dcb07778bbb762223b62cfc3da7
Gerrit-Change-Number: 32499
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Kepplinger martink@posteo.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Kepplinger martink@posteo.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Apr 2019 05:04:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment