19 Nov
2019
19 Nov
'19
12:41 a.m.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36938 )
Change subject: Firmware update support for EM100Pro-G2 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Nits
https://review.coreboot.org/c/em100/+/36938/1/firmware.c File firmware.c:
https://review.coreboot.org/c/em100/+/36938/1/firmware.c@261 PS1, Line 261: EM100Pro EM100Pro Gen 1? EM100Pro (Original)?
https://review.coreboot.org/c/em100/+/36938/1/firmware.c@268 PS1, Line 268: EM100Pro EM100Pro-G2
--
To view, visit https://review.coreboot.org/c/em100/+/36938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I04c60f8fbe9a93048740549aa57d6d85a5db8107
Gerrit-Change-Number: 36938
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 18 Nov 2019 23:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment