Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33782 )
Change subject: vbe.h: Convert hardcode vesa mode into macro
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33782/1/src/include/vbe.h
File src/include/vbe.h:
https://review.coreboot.org/#/c/33782/1/src/include/vbe.h@48
PS1, Line 48: u16 video_mode_list[MAX_VBE_FRAMEBUFFER_MODE];
This struct does not map to the return value of the VBEINFO INT, which just returns a pointer. […]
you are right, this structure should be like this
typedef struct {
char signature[4];
u16 version;
u8 *oem_string_ptr;
u32 capabilities;
u32 *video_mode_ptr;
u16 total_memory;
char reserved[236];
} __packed vbe_info_t;
I can make this code change, even i have done the same but then i have realized that device/oprom/yabel/vbe.c is kind of using info->video_mode_list[256] hence revert my changes.
I can push those changes back and modify my CL accordingly, will you be able to modify device/oprom/yabel/vbe.c accordingly as per vbe spec.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e79b21acf44f6ca184a09d42acdf69c31dd4841
Gerrit-Change-Number: 33782
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 25 Jun 2019 14:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment