Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39530 )
Change subject: soc/intel/Kconfig: Avoid specifying dedicated chipset name
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39530/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39530/3//COMMIT_MSG@13
PS3, Line 13: Rename: src/soc/intel/common/Kconfig to src/soc/intel/common/Kconfig.common
: Change: All specific SoC sources to "source src/soc/intel/*/Kconfig"
: Change: Common source to "source src/soc/intel/common/Kconfig.common"
i thought you have concern in duplicating commit msg. […]
Ok, looks like a misunderstanding. Please tell, how I can phrase it differently in the future, so it’s not missed.
It was about the strange way to formulating these sentences.
Additionally, if some discussion comes up during review, which is clarified in the review comments or even new patchsets, it makes sure that more reasoning/detail is needed in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2d8a8ac1c4acfabd4ded1bfd4ff359e820e174b
Gerrit-Change-Number: 39530
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Mar 2020 07:36:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment