[coreboot-gerrit] Change in coreboot[master]: src/mainboard/*.asl: Remove _HID / _ADR objects

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37935 )

Change subject: src/mainboard/*.asl: Remove _HID / _ADR objects
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/37935/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37935/2//COMMIT_MSG@11 
PS2, Line 11: Untested.
> We can not use _HID and _ADR at the same time

Done

https://review.coreboot.org/c/coreboot/+/37935/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37935/7//COMMIT_MSG@9 
PS7, Line 9: A device object must contain either a _HID object or an _ADR object,
           : but should not contain both.
> what's the logic for removing one vs the other in each case? […]

one of them is wrong.
please see ACPI Specification Version 6.3 - January 2019
page 342

https://review.coreboot.org/c/coreboot/+/37935/3/src/soc/intel/broadwell/acp... 
File src/soc/intel/broadwell/acpi/serialio.asl:

PS3:
> CB:37568 uses `sio_acpi_mode = 0`.

Done