Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34772 )
Change subject: soc/mediatek: dsi: Refactor video timing calculation
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34772/11/src/soc/mediatek/common/ds...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34772/11/src/soc/mediatek/common/ds...
PS11, Line 209: u32 d_phy = data_phy_cycles * lanes + delta;
nit: I hope you checked that this comes out to 12 for 8173, because I'm too lazy ^^
Done
https://review.coreboot.org/c/coreboot/+/34772/11/src/soc/mediatek/common/ds...
PS11, Line 268: mtk_dsi_config_vdo_timing(mode_flags, format, lanes, edid, &phy_timing);
Oh, this is why you passed it out. Okay, fair enough.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3ad2edc08787414a74188f5050460e98222caf4
Gerrit-Change-Number: 34772
Gerrit-PatchSet: 12
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 10 Aug 2019 17:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment